-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Config] Introduce SOFA modules data structure #5148
Open
alxbilger
wants to merge
10
commits into
sofa-framework:master
Choose a base branch
from
alxbilger:modules
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
enhancement
About a possible enhancement
pr: status to review
To notify reviewers to review this pull-request
pr: dev meeting topic
PR to be discussed in sofa-dev meeting
labels
Nov 30, 2024
damienmarchal
referenced
this pull request
Dec 2, 2024
This approach make use of the factory and text description of the object se don't need to include them.
hugtalbot
removed
the
pr: dev meeting topic
PR to be discussed in sofa-dev meeting
label
Dec 4, 2024
[ci-build][with-all-tests][force-full-build] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
About a possible enhancement
pr: status to review
To notify reviewers to review this pull-request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data structure introduced in Config/Modules.h
Comment on the introduced variable:
Note: this allowed to detect 2 typos in
ComponentChange.cpp
. They have been fixed.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if